Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_surface_impl.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
index b9ada9498f928bc03d286242974c20c0c1070e7a..21bf03917d961f739278396b843634c9e96576ec 100644
--- a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
+++ b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
@@ -28,8 +28,8 @@ OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() {
if (!GetSurfaceManager()) {
// Inform both members that SurfaceManager's no longer alive to
// avoid their destruction errors.
- surface_factory_->didDestroySurfaceManager();
- id_allocator_->didDestroySurfaceManager();
+ surface_factory_->did_destroy_surface_manager();
rjkroege 2016/06/28 23:31:55 danakj@'s comment applies here too yes?
+ id_allocator_->did_destroy_surface_manager();
}
surface_factory_->Destroy(surface_id_);
}
@@ -75,7 +75,7 @@ void OffscreenCanvasSurfaceImpl::Satisfy(const cc::SurfaceSequence& sequence) {
void OffscreenCanvasSurfaceImpl::ReturnResources(
const cc::ReturnedResourceArray& resources) {}
-void OffscreenCanvasSurfaceImpl::WillDrawSurface(cc::SurfaceId id,
+void OffscreenCanvasSurfaceImpl::WillDrawSurface(const cc::SurfaceId& id,
const gfx::Rect& damage_rect) {
}

Powered by Google App Engine
This is Rietveld 408576698