components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc - Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/surfaces/surface_id_allocator.h ('K') | « components/mus/gpu/display_compositor/compositor_frame_sink_impl.h ('k') | content/browser/renderer_host/delegated_frame_host.h » ('j') | content/browser/renderer_host/offscreen_canvas_surface_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc

diff --git a/components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc b/components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc

index a18d0319753b02964b670cd9a8210a3a8f871931..a4e072ebec3392a50593c12eea1a03aa08f8bd24 100644

--- a/components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc

+++ b/components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc

@@ -83,7 +83,7 @@ void CompositorFrameSinkImpl::ReturnResources(

client_->ReturnResources(mojo::Array<cc::ReturnedResource>::From(resources));

}

-void CompositorFrameSinkImpl::WillDrawSurface(cc::SurfaceId surface_id,

+void CompositorFrameSinkImpl::WillDrawSurface(const cc::SurfaceId& surface_id,

const gfx::Rect& damage_rect) {

NOTIMPLEMENTED();

}