Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: components/exo/surface.cc

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/surface.cc
diff --git a/components/exo/surface.cc b/components/exo/surface.cc
index cf36bba64303ec95d5a188eaec4012012912fa9a..5a6efe1845801dfaba2b2e48f309d15c2a9b4b56 100644
--- a/components/exo/surface.cc
+++ b/components/exo/surface.cc
@@ -142,15 +142,15 @@ class CustomWindowTargeter : public aura::WindowTargeter {
};
void SatisfyCallback(cc::SurfaceManager* manager,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceSequence& sequence) {
std::vector<uint32_t> sequences;
sequences.push_back(sequence.sequence);
manager->DidSatisfySequences(sequence.id_namespace, &sequences);
}
void RequireCallback(cc::SurfaceManager* manager,
- cc::SurfaceId id,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceId& id,
+ const cc::SurfaceSequence& sequence) {
cc::Surface* surface = manager->GetSurfaceForId(id);
if (!surface) {
LOG(ERROR) << "Attempting to require callback on nonexistent surface";
@@ -180,7 +180,7 @@ void SurfaceFactoryOwner::ReturnResources(
}
}
-void SurfaceFactoryOwner::WillDrawSurface(cc::SurfaceId id,
+void SurfaceFactoryOwner::WillDrawSurface(const cc::SurfaceId& id,
const gfx::Rect& damage_rect) {
if (surface_)
surface_->WillDraw(id);

Powered by Google App Engine
This is Rietveld 408576698