Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: components/exo/surface.cc

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/exo/surface.h ('k') | components/mus/gpu/display_compositor/compositor_frame_sink_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/surface.cc
diff --git a/components/exo/surface.cc b/components/exo/surface.cc
index 077795030e7a49a8b5ddc252f9d9018209231e2e..0822a3d17dfa41f49d67446fe4f87706f559bf36 100644
--- a/components/exo/surface.cc
+++ b/components/exo/surface.cc
@@ -142,15 +142,15 @@ class CustomWindowTargeter : public aura::WindowTargeter {
};
void SatisfyCallback(cc::SurfaceManager* manager,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceSequence& sequence) {
std::vector<uint32_t> sequences;
sequences.push_back(sequence.sequence);
manager->DidSatisfySequences(sequence.id_namespace, &sequences);
}
void RequireCallback(cc::SurfaceManager* manager,
- cc::SurfaceId id,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceId& id,
+ const cc::SurfaceSequence& sequence) {
cc::Surface* surface = manager->GetSurfaceForId(id);
if (!surface) {
LOG(ERROR) << "Attempting to require callback on nonexistent surface";
@@ -180,7 +180,7 @@ void SurfaceFactoryOwner::ReturnResources(
}
}
-void SurfaceFactoryOwner::WillDrawSurface(cc::SurfaceId id,
+void SurfaceFactoryOwner::WillDrawSurface(const cc::SurfaceId& id,
const gfx::Rect& damage_rect) {
if (surface_)
surface_->WillDraw(id);
« no previous file with comments | « components/exo/surface.h ('k') | components/mus/gpu/display_compositor/compositor_frame_sink_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698