Make Satisfy/Require callbacks pass Surface id and sequence by reference

cc/surfaces/surface_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SURFACES_SURFACE_FACTORY_H_
 #define CC_SURFACES_SURFACE_FACTORY_H_
 
 #include <memory>
 #include <set>
 #include <unordered_map>
@@ skipping 67 matching lines @@
   SurfaceManager* manager() { return manager_; }
 
   // This can be set to false if resources from this SurfaceFactory don't need
   // to have sync points set on them when returned from the Display, for
   // example if the Display shares a context with the creator.
   bool needs_sync_points() const { return needs_sync_points_; }
   void set_needs_sync_points(bool needs) { needs_sync_points_ = needs; }
 
   // SurfaceFactory's owner can call this when it finds out that SurfaceManager
   // is no longer alive during destruction.
-  void didDestroySurfaceManager() { manager_ = nullptr; }
+  void did_destroy_surface_manager() { manager_ = nullptr; }

[xlai (Olivia), 2016/06/28 21:16:19]

The previous function name uses Blink style instead of Chromium style.

[danakj, 2016/06/28 22:13:14]

I think I prefer DidDestroySurfaceManager instead.

hacker_style() that doesn't start with set_ looks like an accessor to me. I know
the style guide loosened the times when you're allowed to use it to any "cheap"
function, but I'd prefer that still here.

 
  private:
   SurfaceManager* manager_;
   SurfaceFactoryClient* client_;
   SurfaceResourceHolder holder_;
 
   bool needs_sync_points_;
 
   using OwningSurfaceMap =
       std::unordered_map<SurfaceId, std::unique_ptr<Surface>, SurfaceIdHash>;
   OwningSurfaceMap surface_map_;
 
   DISALLOW_COPY_AND_ASSIGN(SurfaceFactory);
 };
 
 }  // namespace cc
 
 #endif  // CC_SURFACES_SURFACE_FACTORY_H_