third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h - Issue 2102113002: Fix case mapping buffer length divergence for synthetic caps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h

Issue 2102113002: Fix case mapping buffer length divergence for synthetic caps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Turkish test is a progression, rebaselining, Moving comment up in test case Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/text/font-features/caps-casemapping.html ('k') | third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h b/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h

index a8a333038d9f4f41170573226bc41cf150580444..5c4fa118d09414ccf986fbd271a902026e24597b 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h

@@ -6,6 +6,7 @@

#define CaseMappingHarfBuzzBufferFiller_h

#include "wtf/Allocator.h"

+#include "wtf/text/AtomicString.h"

#include "wtf/text/Unicode.h"

#include <hb.h>

@@ -24,6 +25,7 @@ class CaseMappingHarfBuzzBufferFiller {

public:

CaseMappingHarfBuzzBufferFiller(

CaseMapIntend,

+ AtomicString locale,

hb_buffer_t* harfBuzzBuffer,

const UChar* buffer,

unsigned bufferLength,

@@ -31,6 +33,12 @@ public:

unsigned numCharacters);

private:

+ void fillSlowCase(CaseMapIntend,

+ AtomicString locale,

+ const UChar* buffer,

+ unsigned bufferLength,

+ unsigned startIndex,

+ unsigned numCharacters);

hb_buffer_t* m_harfBuzzBuffer;

};