ServiceWorker: Remove [Unforgeable] idl extended attribute.

ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777
Committed: https://crrev.com/77a9444d1b574bb603e5a79d588e6f9e93361b1e
Cr-Commit-Position: refs/heads/master@{#406020}

[zino, 2016-06-28 14:50:22]

Description was changed from

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorkerRegistration and
ServiceWorkerContainer.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=none
==========

to

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorkerRegistration and
ServiceWorkerContainer.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=none
==========

[zino, 2016-07-11 17:10:47]

jinho.bang@samsung.com changed reviewers:
+ nhiroki@chromium.org

[zino, 2016-07-11 17:11:02]

PTAL

[nhiroki, 2016-07-13 04:54:41]

LGTM.

Can you file this issue in crbug.com so that we can easier track the change
later?

[zino, 2016-07-13 10:54:42]

Description was changed from

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorkerRegistration and
ServiceWorkerContainer.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=none
==========

to

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorkerRegistration and
ServiceWorkerContainer.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777
==========

[zino, 2016-07-13 10:55:04]

On 2016/07/13 04:54:41, nhiroki (slow) wrote:
> Can you file this issue in http://crbug.com so that we can easier track the
change
> later?

Done.

Thanks.

[zino, 2016-07-13 10:55:22]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2016-07-13 10:55:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 12:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 12:13:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zino, 2016-07-17 10:03:34]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2016-07-17 10:03:34]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2102093002/#ps40001
(title: "expected")

[zino, 2016-07-17 10:03:35]

The CQ bit was unchecked by jinho.bang@samsung.com

[zino, 2016-07-17 10:04:18]

Patchset #3 (id:40001) has been deleted

[zino, 2016-07-17 14:57:50]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2016-07-17 14:57:50]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2102093002/#ps60001
(title: "expected")

[commit-bot: I haz the power, 2016-07-17 14:57:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2016-07-17 15:02:05]

The CQ bit was unchecked by jinho.bang@samsung.com

[zino, 2016-07-17 15:04:02]

jinho.bang@samsung.com changed reviewers:
+ foolip@chromium.org

[zino, 2016-07-17 15:07:18]

Hi Philip,

PTAL. This patch changes webexposed tests but this is trivial.

[foolip, 2016-07-17 17:00:42]

lgtm

[zino, 2016-07-17 17:07:44]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2016-07-17 17:07:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-07-17 17:45:19]

The CQ bit was unchecked by foolip@chromium.org

[foolip, 2016-07-17 17:47:29]

Unchecking CQ to ask an additional question. Other than the things on Window,
Document, Location and Event that have [Unforgeable] in the specs, Blink also
has it in modules/cachestorage/WindowCacheStorage.idl and
modules/cachestorage/WorkerCacheStorage.idl where the spec does not:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#self-caches

Can you take care of removing those as well? In this very CL seems OK given that
it's the same spec.

[zino, 2016-07-18 14:45:07]

Description was changed from

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorkerRegistration and
ServiceWorkerContainer.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777
==========

to

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777
==========

[zino, 2016-07-18 14:49:57]

On 2016/07/17 17:47:29, foolip wrote:
> Unchecking CQ to ask an additional question. Other than the things on Window,
> Document, Location and Event that have [Unforgeable] in the specs, Blink also
> has it in modules/cachestorage/WindowCacheStorage.idl and
> modules/cachestorage/WorkerCacheStorage.idl where the spec does not:
> https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#self-caches
> 
> Can you take care of removing those as well? In this very CL seems OK given
that
> it's the same spec.

When I was trying to find [Unforgeable] IDLs in cs.chromium.org, I used
[Unforgeable] keyword exactly.

So, I couldn't find cache storage related IDLs because they defined
[Unforgeable, blah blah..].

I removed them anyway.  Thank you.

Could you review this again?

[foolip, 2016-07-18 15:55:12]

lgtm

[zino, 2016-07-18 15:57:15]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2016-07-18 15:57:16]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2102093002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-07-18 15:57:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 17:17:44]

Description was changed from

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777
==========

to

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777
==========

[commit-bot: I haz the power, 2016-07-18 17:17:46]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-07-18 17:17:54]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 17:19:24]

Description was changed from

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777
==========

to

==========
ServiceWorker: Remove [Unforgeable] idl extended attribute.

Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777

Committed: https://crrev.com/77a9444d1b574bb603e5a79d588e6f9e93361b1e
Cr-Commit-Position: refs/heads/master@{#406020}
==========

[commit-bot: I haz the power, 2016-07-18 17:19:26]

Patchset 6 (id:??) landed as
https://crrev.com/77a9444d1b574bb603e5a79d588e6f9e93361b1e
Cr-Commit-Position: refs/heads/master@{#406020}