components/update_client/update_checker_unittest.cc - Issue 2102083002: Allow component installers to specify a map of installer attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/update_checker_unittest.cc

Issue 2102083002: Allow component installers to specify a map of installer attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/component_updater/default_component_installer.h ('K') | « components/update_client/update_checker.cc ('k') | components/update_client/update_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/update_client/update_checker_unittest.cc

diff --git a/components/update_client/update_checker_unittest.cc b/components/update_client/update_checker_unittest.cc

index 9e528dc4dd5d49213e00bf0639fe7ff696a50309..8bac5ea1fc0949423458375206e60436930fc8c9 100644

--- a/components/update_client/update_checker_unittest.cc

+++ b/components/update_client/update_checker_unittest.cc

@@ -170,7 +170,7 @@ TEST_F(UpdateCheckerTest, UpdateCheckSuccess) {

update_checker_ = UpdateChecker::Create(config_, metadata_.get());

CrxUpdateItem item(BuildCrxUpdateItem());

- item.component.ap = "some_ap";

+ item.component.installer_attributes["ap"] = "some_ap";

std::vector<CrxUpdateItem*> items_to_check;

items_to_check.push_back(&item);

@@ -220,7 +220,8 @@ TEST_F(UpdateCheckerTest, UpdateCheckInvalidAp) {

update_checker_ = UpdateChecker::Create(config_, metadata_.get());

CrxUpdateItem item(BuildCrxUpdateItem());

- item.component.ap = std::string(257, 'a'); // Too long.

+ // Make "ap" too long.

+ item.component.installer_attributes["ap"] = std::string(257, 'a');

std::vector<CrxUpdateItem*> items_to_check;

items_to_check.push_back(&item);