Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2102083002: Allow component installers to specify a map of installer attributes. (Closed)

Created:
4 years, 5 months ago by Sorin Jianu
Modified:
4 years, 5 months ago
Reviewers:
waffles
CC:
chromium-reviews, pam+watch_chromium.org, chasej+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This is a mechanical change. Allow component installers to specify a map of installer attributes to be used in the update check requests. This change extends the mechanism to specify "ap" in such a way that a map of name-value pairs can be returned by the component installer which need this capability. R=waffles BUG=599703 Committed: https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46 Cr-Commit-Position: refs/heads/master@{#402632}

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -78 lines) Patch
M chrome/browser/component_updater/caps_installer_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/file_type_policies_component_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/file_type_policies_component_installer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/origin_trials_component_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/origin_trials_component_installer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/sth_set_component_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/sth_set_component_installer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/subresource_filter_component_installer.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/component_updater/subresource_filter_component_installer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/supervised_user_whitelist_installer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/component_updater/default_component_installer.h View 1 2 3 1 chunk +9 lines, -5 lines 0 comments Download
M components/component_updater/default_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/default_component_installer_unittest.cc View 1 4 chunks +14 lines, -4 lines 0 comments Download
M components/update_client/update_checker.cc View 1 4 chunks +17 lines, -6 lines 0 comments Download
M components/update_client/update_checker_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M components/update_client/update_client.h View 1 2 3 chunks +11 lines, -1 line 0 comments Download
M components/update_client/utils.h View 1 3 chunks +10 lines, -2 lines 0 comments Download
M components/update_client/utils.cc View 1 1 chunk +26 lines, -7 lines 0 comments Download
M components/update_client/utils_unittest.cc View 1 1 chunk +50 lines, -24 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Sorin Jianu
4 years, 5 months ago (2016-06-28 21:42:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102083002/40001
4 years, 5 months ago (2016-06-28 21:44:28 UTC) #4
Sorin Jianu
https://codereview.chromium.org/2102083002/diff/40001/components/component_updater/default_component_installer.h File components/component_updater/default_component_installer.h (right): https://codereview.chromium.org/2102083002/diff/40001/components/component_updater/default_component_installer.h#newcode91 components/component_updater/default_component_installer.h:91: I will handle this empty line.
4 years, 5 months ago (2016-06-28 21:46:11 UTC) #5
waffles
lgtm
4 years, 5 months ago (2016-06-28 21:50:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102083002/60001
4 years, 5 months ago (2016-06-28 22:04:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/247107)
4 years, 5 months ago (2016-06-28 23:42:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102083002/60001
4 years, 5 months ago (2016-06-28 23:44:47 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-29 01:44:53 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 01:48:00 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46
Cr-Commit-Position: refs/heads/master@{#402632}

Powered by Google App Engine
This is Rietveld 408576698