Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2102053002: sandwich: Properly detect page load failures (Closed)

Created:
4 years, 5 months ago by gabadie
Modified:
4 years, 5 months ago
Reviewers:
pasko
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@af00
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandwich: Properly detect page load failures BUG=582080 Committed: https://crrev.com/5ca99b2df9e139cc5a67648462b9610183025fdb Cr-Commit-Position: refs/heads/master@{#402499}

Patch Set 1 #

Patch Set 2 : Rebase on landing dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/android/loading/sandwich_runner.py View 1 3 chunks +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2103673003 Patch 90001

Messages

Total messages: 9 (4 generated)
gabadie
Hey Egor, Small patch to properly handle loading failure in sandwich runner. PTAL.
4 years, 5 months ago (2016-06-28 12:51:25 UTC) #2
pasko
lgtm
4 years, 5 months ago (2016-06-28 13:09:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102053002/20001
4 years, 5 months ago (2016-06-28 15:53:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 17:34:35 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 17:38:07 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5ca99b2df9e139cc5a67648462b9610183025fdb
Cr-Commit-Position: refs/heads/master@{#402499}

Powered by Google App Engine
This is Rietveld 408576698