Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2102043002: Add markedLabel property to InfoBarViewProtocol (Closed)

Created:
4 years, 5 months ago by Jackie Quinn
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@confirm_protected_header
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add markedLabel property to InfoBarViewProtocol Add markedLabel property to InfoBarViewProtocol to allow subclasses of info bar controllers to modify labels with existing links. BUG=622244 Committed: https://crrev.com/7284bd53e2e861b5a6b718a9d8d4d05a7818b9d4 Cr-Commit-Position: refs/heads/master@{#402844}

Patch Set 1 #

Patch Set 2 : Add markedLabel property to InfoBarViewProtocol #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/ui/infobar_view_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jackie Quinn
4 years, 5 months ago (2016-06-28 12:44:56 UTC) #2
jif
lgtm
4 years, 5 months ago (2016-06-28 15:47:57 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years, 5 months ago (2016-06-29 11:57:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102043002/20001
4 years, 5 months ago (2016-06-29 16:20:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 17:16:16 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:16:25 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 17:19:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7284bd53e2e861b5a6b718a9d8d4d05a7818b9d4
Cr-Commit-Position: refs/heads/master@{#402844}

Powered by Google App Engine
This is Rietveld 408576698