Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 210203005: Pages are missing invalidations (Closed)

Created:
6 years, 9 months ago by Julien - ping for review
Modified:
6 years, 9 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Pages are missing invalidations r168968 made us avoid full invalidations in repaintAfterLayoutIfNeeded for shifted renderers. This is wrong as inserted / removed renderers can shift content without marking them for layout. The old logic would rely on the outline box to detect the previous case and force a full invalidation but r168968 disabled the outline box checks unless you have an outline. This change brings back the full-invalidation-on-shifted-renderer, which brings back some missing invalidations. The new baselines are matching pre-r168968 baselines but we haven't completely reverted the changes from r168968 so it's still an overall win. BUG=353933 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170066

Patch Set 1 #

Patch Set 2 : Improved the test cases. #

Patch Set 3 : Fixed TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -38 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-on-layout-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/repaint/abspos-shift-image-incorrect-repaint-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/scroll-in-transformed-layer-expected.txt View 1 chunk +2 lines, -5 lines 0 comments Download
A LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-addition.html View 1 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-removal.html View 1 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-removal-expected.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/transform-absolute-child-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/platform/win/css3/flexbox/repaint-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/4776765-expected.txt View 1 chunk +4 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/float-overflow-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/float-overflow-right-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/outline-shrinking-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Julien - ping for review
6 years, 9 months ago (2014-03-25 20:17:13 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-25 20:46:06 UTC) #2
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-26 00:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/210203005/100001
6 years, 9 months ago (2014-03-26 00:44:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 01:10:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 01:10:35 UTC) #6
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-26 15:13:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/210203005/100001
6 years, 9 months ago (2014-03-26 15:13:49 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 17:44:57 UTC) #9
Message was sent while issue was closed.
Change committed as 170066

Powered by Google App Engine
This is Rietveld 408576698