|
Pages are missing invalidations
r168968 made us avoid full invalidations in repaintAfterLayoutIfNeeded
for shifted renderers. This is wrong as inserted / removed renderers
can shift content without marking them for layout.
The old logic would rely on the outline box to detect the previous
case and force a full invalidation but r168968 disabled the outline
box checks unless you have an outline.
This change brings back the full-invalidation-on-shifted-renderer,
which brings back some missing invalidations. The new baselines are
matching pre-r168968 baselines but we haven't completely reverted
the changes from r168968 so it's still an overall win.
BUG= 353933
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170066
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+142 lines, -38 lines) |
Patch |
 |
M |
LayoutTests/TestExpectations
|
View
|
1
2
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/css3/flexbox/repaint-on-layout-expected.txt
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/repaint/abspos-shift-image-incorrect-repaint-expected.txt
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/repaint/scroll-in-transformed-layer-expected.txt
|
View
|
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
A |
LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-addition.html
|
View
|
1
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
 |
A |
LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt
|
View
|
1
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
 |
A |
LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-removal.html
|
View
|
1
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
 |
A |
LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-removal-expected.txt
|
View
|
1
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/repaint/transform-absolute-child-expected.txt
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/css3/flexbox/repaint-expected.txt
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/repaint/4776765-expected.txt
|
View
|
|
1 chunk |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/repaint/float-overflow-expected.txt
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/repaint/float-overflow-right-expected.txt
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/repaint/outline-shrinking-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderObject.cpp
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
Total messages: 9 (0 generated)
|