Add ContentSuggestionsService

components/ntp_snippets/content_suggestions_category_status.h

Index: components/ntp_snippets/content_suggestions_category_status.h
diff --git a/components/ntp_snippets/content_suggestions_category_status.h b/components/ntp_snippets/content_suggestions_category_status.h
new file mode 100644
index 0000000000000000000000000000000000000000..d2bfbf7ea467547f25b519c409f93365f5ffb297
--- /dev/null
+++ b/components/ntp_snippets/content_suggestions_category_status.h
@@ -0,0 +1,50 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_STATUS_H_
+#define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_STATUS_H_
+
+namespace ntp_snippets {
+
+// Represents the status of a category of content suggestions.
+// On Android builds, a Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.ntp.snippets
+enum class ContentSuggestionsCategoryStatus : int {

[tschumann, 2016/07/06 06:36:12]

nit: drop the ': int'? We shouldn't overspecify if we don't need them.

[Philipp Keck, 2016/07/06 08:34:23]

Could be dropped unless the Android bridge needs them. I think the Java enum
generator needs those int values to ensure that they match?

[tschumann, 2016/07/06 14:49:43]

I see. Uf the bridge needs it, it makes totally sense to keep =).

[Philipp Keck, 2016/07/06 15:53:20]

Acknowledged.

[Bernhard Bauer, 2016/07/07 09:42:38]

FTR: The java enum generator doesn't need the underlying type, and the JNI
bridge (which is independent!) will use jint anyway (which happens to be
typedef'd to int).

[Philipp Keck, 2016/07/07 09:52:22]

Ok, so the Android bridge would work without the ": int"? I haven't implemented
the Android part yet, so I don't know if it would work. The enum where most of
these values here come from
(https://codesearch.chromium.org/chromium/src/components/ntp_snippets/ntp_snip...)
uses ": int" and that's why I have it here.
To the DisabledReason enum it was added here
https://codereview.chromium.org/2061803002/diff/120001/components/ntp_snippet...,
probably to make the static_cast<int> in the bridge possible
https://codereview.chromium.org/2061803002/diff/120001/chrome/browser/android...
?

[Bernhard Bauer, 2016/07/07 10:29:08]

The java enum generator works without the ": int" -- it's just a script, and it
doesn't look at the underlying type. JNI doesn't need the underlying type
*declaration* either, as that only depends on the type used by the compiler (not
the source code), and it knows how to cast the type (and if the underlying type
for the enum happens to be the same as a jint, it will be a no-op anyway).

[Philipp Keck, 2016/07/07 12:22:29]

Ok I removed it and so far nothing breaks :-)

+  // Content suggestions are available (though the list of available suggestions
+  // may be empty simply because there are no reasonable suggestions to be made
+  // at the moment).
+  AVAILABLE,
+  // Content suggestions are provided but not yet loaded.
+  AVAILABLE_LOADING,
+
+  // There is no provider that provides suggestions for this category.
+  NOT_PROVIDED,
+  // The entire content suggestions feature has explicitly been disabled as part
+  // of the service configuration.
+  ALL_SUGGESTIONS_EXPLICITLY_DISABLED,
+  // Content suggestions from a specific category have been disabled as part of
+  // the service configuration.
+  CATEGORY_EXPLICITLY_DISABLED,
+
+  // Content suggestions are not available because the user is not signed in.
+  SIGNED_OUT,
+  // Content suggestions are not available because sync is disabled.
+  SYNC_DISABLED,
+  // Content suggestions are not available because passphrase encryption is
+  // enabled (and it should be disabled).
+  PASSPHRASE_ENCRYPTION_ENABLED,
+  // Content suggestions are not available because history sync is disabled.
+  HISTORY_SYNC_DISABLED,
+  // Content suggestions are not available because the history sync service is
+  // not yet completely initialized and its status is unknown.
+  HISTORY_SYNC_STATE_UNKNOWN
+};
+
+// Determines whether the given status is one of the AVAILABLE statuses.
+bool IsContentSuggestionsCategoryStatusAvailable(
+    ContentSuggestionsCategoryStatus status);
+
+}  // namespace ntp_snippets
+
+#endif  // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_STATUS_H_