components/ntp_snippets/ntp_snippet.h - Issue 2102023002: Add ContentSuggestionsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippet.h

Issue 2102023002: Add ContentSuggestionsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove ContentSuggestionsServiceType; allow at most one provider per category Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/ntp_snippet.h

diff --git a/components/ntp_snippets/ntp_snippet.h b/components/ntp_snippets/ntp_snippet.h

index 416cffca7dbedbd016b845a4271d2416c0d4d96d..e4e4eae9ef5c2c4cc3978599a0beb936c72e047f 100644

--- a/components/ntp_snippets/ntp_snippet.h

+++ b/components/ntp_snippets/ntp_snippet.h

@@ -126,7 +126,8 @@ class NTPSnippet {

bool is_discarded() const { return is_discarded_; }

void set_discarded(bool discarded) { is_discarded_ = discarded; }

- std::unique_ptr<ContentSuggestion> ToContentSuggestion() const;

+ std::unique_ptr<ContentSuggestion> ToContentSuggestion(

+ const std::string& id) const;

Marc Treib 2016/07/05 13:17:12 Mh, this is ugly... so the caller has to get the I

Philipp Keck 2016/07/05 13:52:00 Done. Now that MakeUniqueID is static, that call c

// Public for testing.

static base::Time TimeFromJsonString(const std::string& timestamp_str);