Move nacl.gypi to components.

chrome/chrome_exe.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'chrome',
       'type': 'executable',
       'mac_bundle': 1,
@@ skipping 597 matching lines @@
           'targets': [
             {
               'target_name': 'chrome_nacl_win64',
               'type': 'none',
               'sources': [],
             },
           ],
         }],
       ],
     }],
+    ['OS=="linux"', {
+      'targets': [
+        {
+          'target_name': 'nacl_helper',

[Mark Seaborn, 2013/07/31 17:16:32]

I'd rather keep the definition of nacl_helper under chrome/nacl/.  It makes
changing it easier (because of OWNERS files).  It makes it easier to find
NaCl-related code, and it should make it easier to tell when componentisation of
NaCl is finished.

[yael.aharon1, 2013/07/31 17:24:38]

Are you suggesting a new gypi file under chrome/nacl? If so, where would it be
included?

[Mark Seaborn, 2013/07/31 17:53:53]

No, I'm just suggesting keeping chrome/nacl/nacl.gypi defining nacl_helper, but
remove from chrome/nacl/nacl.gypi all the stuff you're moving to
components/nacl.gypi.

+          'type': 'executable',
+          'include_dirs': [
+            '..',
+          ],
+          'dependencies': [
+            'nacl',
+            '../components/nacl_common.gyp:nacl_common',
+            '../crypto/crypto.gyp:crypto',
+            '../sandbox/sandbox.gyp:libc_urandom_override',
+            '../sandbox/sandbox.gyp:sandbox',
+          ],
+          'sources': [
+            'nacl/nacl_helper_linux.cc',
+            '../base/posix/unix_domain_socket_linux.cc',
+            '../components/nacl/loader/nacl_sandbox_linux.cc',
+            '../content/common/child_process_sandbox_support_impl_shm_linux.cc',
+            '../content/common/sandbox_init_linux.cc',
+            '../content/common/sandbox_seccomp_bpf_linux.cc',
+            '../content/public/common/content_switches.cc',
+          ],
+          'conditions': [
+            ['toolkit_uses_gtk == 1', {
+              'dependencies': [
+                '../build/linux/system.gyp:gtk',
+              ],
+            }],
+            ['use_glib == 1', {
+              'dependencies': [
+                '../build/linux/system.gyp:glib',
+              ],
+            }],
+            ['os_posix == 1 and OS != "mac"', {
+              'conditions': [
+                ['linux_use_tcmalloc==1', {
+                  'dependencies': [
+                    '../base/allocator/allocator.gyp:allocator',
+                  ],
+                }],
+              ],
+            }],
+          ],
+          'cflags': ['-fPIE'],
+          'link_settings': {
+            'ldflags': ['-pie'],
+          },
+        },
+      ],
+    }],
     ['test_isolation_mode != "noop"', {
       'targets': [
         {
           'target_name': 'chrome_run',
           'type': 'none',
           'dependencies': [
             'chrome',
           ],
           'includes': [
             '../build/isolate.gypi',
             'chrome.isolate',
           ],
           'sources': [
             'chrome.isolate',
           ],
           'conditions': [
             ['OS=="win"', {
               'dependencies': [
                 'chrome_nacl_win64',
               ],
             }],
           ],
         },
       ],
     }],
   ],
 }