Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2101983004: Remove incorrect asserts in PaymentRequest (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, Khushal
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect asserts in PaymentRequest When creating a new contact, the AutofillContact object is created with both null phone number and null email address. Therefore, asserts that one of them should be not null are not correct. This patch removes these asserts. BUG=624211 Committed: https://crrev.com/d838a56193c7994c3abb9e9cfc1462a7e19d5f53 Cr-Commit-Position: refs/heads/master@{#402642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
please use gerrit instead
dfalcantara@, ptal. khushalsagar@, fyi. This should fix the integration tests.
4 years, 5 months ago (2016-06-29 00:48:24 UTC) #2
gone
lgtm
4 years, 5 months ago (2016-06-29 00:49:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101983004/1
4 years, 5 months ago (2016-06-29 00:51:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101983004/1
4 years, 5 months ago (2016-06-29 00:53:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 01:52:44 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 01:54:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d838a56193c7994c3abb9e9cfc1462a7e19d5f53
Cr-Commit-Position: refs/heads/master@{#402642}

Powered by Google App Engine
This is Rietveld 408576698