net/http/http_util.cc - Issue 2101963002: Skip header lines with invalid header name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_util.cc

Issue 2101963002: Skip header lines with invalid header name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_util.cc

diff --git a/net/http/http_util.cc b/net/http/http_util.cc

index 06fc15edd3668e367d0551cf4314de04beb73c65..06eb55e70bca89b20a019a75ee3ba0ff8823558d 100644

--- a/net/http/http_util.cc

+++ b/net/http/http_util.cc

@@ -910,7 +910,7 @@ bool HttpUtil::HeadersIterator::GetNext() {

continue;

TrimLWS(&name_begin_, &name_end_);

- if (name_begin_ == name_end_)

+ if (!IsToken(name_begin_, name_end_))

continue; // skip malformed header

values_begin_ = colon + 1;

« no previous file with comments | « no previous file | net/http/http_util_unittest.cc » ('j') | no next file with comments »