Skip header lines with invalid header name

net/http/http_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The rules for parsing content-types were borrowed from Firefox:
 // http://lxr.mozilla.org/mozilla/source/netwerk/base/src/nsURLHelper.cpp#834
 
 #include "net/http/http_util.h"
 
 #include <algorithm>
@@ skipping 892 matching lines @@
 
     name_end_ = colon;
 
     // If the name starts with LWS, it is an invalid line.
     // Leading LWS implies a line continuation, and these should have
     // already been joined by AssembleRawHeaders().
     if (name_begin_ == name_end_ || IsLWS(*name_begin_))
       continue;
 
     TrimLWS(&name_begin_, &name_end_);
-    if (name_begin_ == name_end_)
+    if (!IsToken(name_begin_, name_end_))

[mmenke, 2016/06/28 14:54:00]

IsValidHeaderName seems clearer (It just calls IsToken, so it does the exact
same thing).

[robwu, 2016/06/28 15:24:42]

IsValidHeaderName takes a std::string, while we only have two iterators.

[mmenke, 2016/06/28 15:26:17]

Oops, good point.

       continue;  // skip malformed header
 
     values_begin_ = colon + 1;
     TrimLWS(&values_begin_, &values_end_);
 
     // if we got a header name, then we are done.
     return true;
   }
   return false;
 }
@@ skipping 148 matching lines @@
   return true;
 }
 
 bool HttpUtil::NameValuePairsIterator::IsQuote(char c) const {
   if (strict_quotes_)
     return c == '"';
   return HttpUtil::IsQuote(c);
 }
 
 }  // namespace net