[Refactoring] Clean up code for serializing ScriptValues

Clean up code for serializing ScriptValues
- Replace '0' with nullptr for null pointers
- Remove needless class name prefixes
- Drop needless methods
- Merge splitted method categories (public/private/protected)
- Use anonymous namespace instead of "static"

BUG=614919
Committed: https://crrev.com/a7aaf9ae89c0a4bc090fa953ebd51b22f477c455
Cr-Commit-Position: refs/heads/master@{#402747}

[peria, 2016-06-28 08:03:24]

Description was changed from

==========
Clean up code for serializing ScriptValues

BUG=614919
==========

to

==========
Clean up code for serializing ScriptValues
- Replace '0' with nullptr for null pointers
- Remove needless class name prefixes
- Drop needless methods
- Merge splitted method categories (public/private/protected)
- Use anonymous namespace instead of "static"


BUG=614919
==========

[peria, 2016-06-28 08:05:03]

peria@chromium.org changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org

[peria, 2016-06-28 08:05:03]

PTL.
This is the last refactoring CL.

[haraken, 2016-06-28 08:10:30]

LGTM

[peria, 2016-06-28 08:12:04]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2016-06-28 08:12:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-06-28 08:28:47]

https://codereview.chromium.org/2101953002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2101953002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:81:
v8::Local<v8::Object> toV8Object(MessagePort* impl, v8::Local<v8::Object>
creationContext, v8::Isolate* isolate)
No need to address in this CL but just a suggestion.

1. We can use template functions for these utility functions.
2. For the empty handle, it's safe to convert it to another type.  So I think we
can write
    toV8(impl, creationContext, isolate).As<v8::Object>()
3. Is that possible that |impl| is nullptr?  If not, what we need is one-line
code above.
  If so, do we need these functions at all?

Note that toV8(nullptr, ...) returns v8::Null that is not type of v8::Object.

[Yuki, 2016-06-28 08:28:58]

LGTM.

[peria, 2016-06-28 08:59:20]

https://codereview.chromium.org/2101953002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2101953002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:81:
v8::Local<v8::Object> toV8Object(MessagePort* impl, v8::Local<v8::Object>
creationContext, v8::Isolate* isolate)
On 2016/06/28 08:28:47, Yuki wrote:
> No need to address in this CL but just a suggestion.
> 
> 1. We can use template functions for these utility functions.
> 2. For the empty handle, it's safe to convert it to another type.  So I think
we
> can write
>     toV8(impl, creationContext, isolate).As<v8::Object>()
> 3. Is that possible that |impl| is nullptr?  If not, what we need is one-line
> code above.
>   If so, do we need these functions at all?
> 
> Note that toV8(nullptr, ...) returns v8::Null that is not type of v8::Object.

Thank you for pointing this out.
I'll do it in another CL.

[commit-bot: I haz the power, 2016-06-28 09:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 09:03:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[peria, 2016-06-29 07:04:41]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2016-06-29 07:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 07:29:39]

Description was changed from

==========
Clean up code for serializing ScriptValues
- Replace '0' with nullptr for null pointers
- Remove needless class name prefixes
- Drop needless methods
- Merge splitted method categories (public/private/protected)
- Use anonymous namespace instead of "static"


BUG=614919
==========

to

==========
Clean up code for serializing ScriptValues
- Replace '0' with nullptr for null pointers
- Remove needless class name prefixes
- Drop needless methods
- Merge splitted method categories (public/private/protected)
- Use anonymous namespace instead of "static"


BUG=614919
==========

[commit-bot: I haz the power, 2016-06-29 07:29:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 07:31:31]

Description was changed from

==========
Clean up code for serializing ScriptValues
- Replace '0' with nullptr for null pointers
- Remove needless class name prefixes
- Drop needless methods
- Merge splitted method categories (public/private/protected)
- Use anonymous namespace instead of "static"


BUG=614919
==========

to

==========
Clean up code for serializing ScriptValues
- Replace '0' with nullptr for null pointers
- Remove needless class name prefixes
- Drop needless methods
- Merge splitted method categories (public/private/protected)
- Use anonymous namespace instead of "static"

BUG=614919

Committed: https://crrev.com/a7aaf9ae89c0a4bc090fa953ebd51b22f477c455
Cr-Commit-Position: refs/heads/master@{#402747}
==========

[commit-bot: I haz the power, 2016-06-29 07:31:32]

Patchset 1 (id:??) landed as
https://crrev.com/a7aaf9ae89c0a4bc090fa953ebd51b22f477c455
Cr-Commit-Position: refs/heads/master@{#402747}