Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2101943005: [turbofan] Always defer replacement in simplified lowering. (Closed)

Created:
4 years, 5 months ago by Jarin
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Always defer replacement in simplified lowering. Since we do negative type checks, the current shortcut might still affect the lowering choices, possibly leading to inconsistent results. This CL gets rid of the shortcut. Committed: https://crrev.com/10714b633cbba472b1e68e6063a6d89ee903f5e6 Cr-Commit-Position: refs/heads/master@{#37412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please? As far as I can see, this fixes the ...
4 years, 5 months ago (2016-06-29 12:06:34 UTC) #3
Benedikt Meurer
LGTM, thanks.
4 years, 5 months ago (2016-06-29 12:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101943005/1
4 years, 5 months ago (2016-06-30 05:36:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 05:38:30 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 05:39:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10714b633cbba472b1e68e6063a6d89ee903f5e6
Cr-Commit-Position: refs/heads/master@{#37412}

Powered by Google App Engine
This is Rietveld 408576698