Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2101943003: Use StringPiece in form_saver_impl_unittest.cc early on (Closed)

Created:
4 years, 5 months ago by vabr (Chromium)
Modified:
4 years, 5 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@621355-wipe
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringPiece in form_saver_impl_unittest.cc early on This is a clean-up CL to replace const char* with StringPiece in a signature of helper functions in a unittest. R=vasilii@chromium.org BUG=621355 Committed: https://crrev.com/2a9cd2e10e39bab3fea3fe792984bbac5becd1f4 Cr-Commit-Position: refs/heads/master@{#402750}

Patch Set 1 #

Patch Set 2 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/password_manager/core/browser/form_saver_impl_unittest.cc View 1 4 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
vabr (Chromium)
Hi Vasilii, I forgot to send this to you. PTAL. Cheers, Vaclav
4 years, 5 months ago (2016-06-28 14:45:29 UTC) #1
vasilii
lgtm
4 years, 5 months ago (2016-06-28 15:04:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101943003/20001
4 years, 5 months ago (2016-06-28 16:02:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 17:36:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101943003/20001
4 years, 5 months ago (2016-06-29 07:29:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 07:33:30 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 07:35:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a9cd2e10e39bab3fea3fe792984bbac5becd1f4
Cr-Commit-Position: refs/heads/master@{#402750}

Powered by Google App Engine
This is Rietveld 408576698