Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2101933006: s390: [turbofan] Make sure binop results do not overwrite deoptimization inputs on arm. (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: [turbofan] Make sure binop results do not overwrite deoptimization inputs on arm. Port e60c4053c7f9d6e44b995c77ab3ec561aec83c9c this fix applies to s390 as well. R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/502cb17918547063b7ea8712d255bddbadb22ec1 Cr-Commit-Position: refs/heads/master@{#37441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-06-30 11:09:52 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-06-30 13:02:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101933006/1
4 years, 5 months ago (2016-06-30 13:02:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 13:26:49 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 13:28:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/502cb17918547063b7ea8712d255bddbadb22ec1
Cr-Commit-Position: refs/heads/master@{#37441}

Powered by Google App Engine
This is Rietveld 408576698