chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js - Issue 2101933005: [MD Extensions] Implement keyboard shortcuts page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js

Issue 2101933005: [MD Extensions] Implement keyboard shortcuts page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits + latest master Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/extensions/cr_extensions_browsertest.js ('k') | chrome/test/data/webui/extensions/extension_shortcut_input_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js

diff --git a/chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js b/chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js

index 115399de641470eb9b786d15be8da0ca2731e046..f2935d77b2c87e9bc7d9bee26b2db695d393722d 100644

--- a/chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js

+++ b/chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js

@@ -82,15 +82,11 @@ cr.define('extension_keyboard_shortcut_tests', function() {

var commands = card1.querySelectorAll('.command-entry');

assertEquals(1, commands.length);

expectTrue(isVisibleOnCard(commands[0], '.command-name'));

- expectTrue(isVisibleOnCard(commands[0], '.command-keys'));

- expectFalse(isVisibleOnCard(commands[0], '.no-command-set'));

expectTrue(isVisibleOnCard(commands[0], 'paper-dropdown-menu'));

var card2 = cards[1];

commands = card2.querySelectorAll('.command-entry');

assertEquals(2, commands.length);

- expectFalse(isVisibleOnCard(commands[1], '.command-keys'));

- expectTrue(isVisibleOnCard(commands[1], '.no-command-set'));

expectEquals(