Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2744)

Unified Diff: chrome/browser/resources/md_extensions/keyboard_shortcuts.html

Issue 2101933005: [MD Extensions] Implement keyboard shortcuts page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits + latest master Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/keyboard_shortcuts.html
diff --git a/chrome/browser/resources/md_extensions/keyboard_shortcuts.html b/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
index 6fad24d4ec97acc255b3c6df6fd480b5c2c1c586..ef81412e9bc8bf1ac413b70901536188008f3f29 100644
--- a/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
+++ b/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
@@ -6,7 +6,7 @@
<link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-listbox.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html">
<link rel="import" href="chrome://extensions/animation_helper.html">
-<link rel="import" href="chrome://extensions/shortcut_util.html">
+<link rel="import" href="chrome://extensions/shortcut_input.html">
<dom-module id="extensions-keyboard-shortcuts">
<template>
@@ -58,16 +58,12 @@
</div>
<div class="card-controls">
<template is="dom-repeat" items="[[item.commands]]" as="command">
- <div class="command-entry">
+ <div class="command-entry" command="[[command]]">
<span class="command-name">[[command.description]]</span>
- <span class="command-keys"
- hidden$="[[!hasKeybinding_(command.keybinding)]]">
- [[command.keybinding]]
- </span>
- <span class="no-command-set"
- hidden$="[[hasKeybinding_(command.keybinding)]]">
- $i18n{shortcutNotSet}
- </span>
+ <extensions-shortcut-input item="[[item.id]]"
+ shortcut="[[command.keybinding]]"
+ command-name="[[command.name]]">
+ </extensions-shortcut-input>
<paper-dropdown-menu label="$i18n{shortcutScopeLabel}">
<paper-listbox class="dropdown-content"
selected="[[computeSelectedScope_(command)]]">
« no previous file with comments | « chrome/browser/resources/md_extensions/compiled_resources2.gyp ('k') | chrome/browser/resources/md_extensions/service.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698