Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2101933003: [Gin] Enable V8 Ignition interpreter for low end Android devices. (Closed)

Created:
4 years, 5 months ago by rmcilroy
Modified:
4 years, 5 months ago
CC:
chromium-reviews, Michael Hablich, mythria, oth, picksi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Gin] Enable V8 Ignition interpreter for low end Android devices. Enable V8 Ignition interpreter for Ignition on low-end (Svelte) devices. This is still controlled by a field-trial flag and so can be turned off in the field if necessary. Perf Sheriffs: This CL is likely to cause regressions on some benchmarks This is expected, as we are trading off memory usage for benchmark performance on low-memory devices, but please file bugs against me for tracking. BUG=v8:4280, v8:4868, 594228 Committed: https://crrev.com/f407ceccdc10ccd6e277fb72675fcf0be040cded Cr-Commit-Position: refs/heads/master@{#402472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gin/gin_features.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rmcilroy
Jochen: After chatting with the Chrome Android TPMs we decided that rather than turning on ...
4 years, 5 months ago (2016-06-28 13:55:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101933003/1
4 years, 5 months ago (2016-06-28 13:55:53 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-28 14:08:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 15:00:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101933003/1
4 years, 5 months ago (2016-06-28 15:05:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 15:10:36 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 15:12:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f407ceccdc10ccd6e277fb72675fcf0be040cded
Cr-Commit-Position: refs/heads/master@{#402472}

Powered by Google App Engine
This is Rietveld 408576698