Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: ui/views/controls/textfield/textfield_unittest.cc

Issue 2101903002: MacViews: Modify cocoa_test_event_utils::SynthesizeKeyEvent to use the correct event timestamp value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct header order. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/test/cocoa_test_event_utils.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield_unittest.cc
diff --git a/ui/views/controls/textfield/textfield_unittest.cc b/ui/views/controls/textfield/textfield_unittest.cc
index 4de82b0a20be2f97ede82427d5dcb64d62d9a632..b40de20b5fcd77bc9c8f7729fefcd4de45fcdb0c 100644
--- a/ui/views/controls/textfield/textfield_unittest.cc
+++ b/ui/views/controls/textfield/textfield_unittest.cc
@@ -1128,13 +1128,7 @@ TEST_F(TextfieldTest, CursorMovement) {
EXPECT_STR_EQ("one two", last_contents_);
}
-// Disabled on Mac (synthesized event bug). http://crbug.com/623420.
-#if defined(OS_MACOSX)
-#define MAYBE_FocusTraversalTest DISABLED_FocusTraversalTest
-#else
-#define MAYBE_FocusTraversalTest FocusTraversalTest
-#endif
-TEST_F(TextfieldTest, MAYBE_FocusTraversalTest) {
+TEST_F(TextfieldTest, FocusTraversalTest) {
InitTextfields(3);
textfield_->RequestFocus();
@@ -1592,13 +1586,7 @@ TEST_F(TextfieldTest, ReadOnlyTest) {
EXPECT_STR_EQ(" four five six ", textfield_->GetSelectedText());
}
-// Disabled on Mac (synthesized event bug). http://crbug.com/623420.
-#if defined(OS_MACOSX)
-#define MAYBE_TextInputClientTest DISABLED_TextInputClientTest
-#else
-#define MAYBE_TextInputClientTest TextInputClientTest
-#endif
-TEST_F(TextfieldTest, MAYBE_TextInputClientTest) {
+TEST_F(TextfieldTest, TextInputClientTest) {
InitTextfield();
ui::TextInputClient* client = textfield_;
EXPECT_TRUE(client);
@@ -2502,15 +2490,7 @@ TEST_F(TextfieldTest, GetTextfieldBaseline_FontFallbackTest) {
// Tests that a textfield view can be destroyed from OnKeyEvent() on its
// controller and it does not crash.
-// Disabled on Mac (synthesized event bug). http://crbug.com/623420.
-#if defined(OS_MACOSX)
-#define MAYBE_DestroyingTextfieldFromOnKeyEvent \
- DISABLED_DestroyingTextfieldFromOnKeyEvent
-#else
-#define MAYBE_DestroyingTextfieldFromOnKeyEvent \
- DestroyingTextfieldFromOnKeyEvent
-#endif
-TEST_F(TextfieldTest, MAYBE_DestroyingTextfieldFromOnKeyEvent) {
+TEST_F(TextfieldTest, DestroyingTextfieldFromOnKeyEvent) {
InitTextfield();
// The controller assumes ownership of the textfield.
« no previous file with comments | « ui/events/test/cocoa_test_event_utils.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698