Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2101883002: ARC: Wire minimizing windows from shelf. (Closed)

Created:
4 years, 5 months ago by mtomasz
Modified:
4 years, 5 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARC: Wire minimizing windows from shelf. BUG=b/28602162 Committed: https://crrev.com/580ba0b914701239c244eefe7ca032f827629160 Cr-Commit-Position: refs/heads/master@{#402619}

Patch Set 1 #

Patch Set 2 : Fix animations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
mtomasz
@reveman: Tested and works. But I'm not sure maybe we should call exo::ShellSurface::Minimize()?
4 years, 5 months ago (2016-06-28 02:23:02 UTC) #3
reveman
On 2016/06/28 at 02:23:02, mtomasz wrote: > @reveman: Tested and works. But I'm not sure ...
4 years, 5 months ago (2016-06-28 08:34:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101883002/20001
4 years, 5 months ago (2016-06-29 00:19:39 UTC) #8
mtomasz
@oshima: PTAL. Thanks!
4 years, 5 months ago (2016-06-29 00:22:37 UTC) #10
oshima
lgtm
4 years, 5 months ago (2016-06-29 00:38:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 00:42:17 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:44:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/580ba0b914701239c244eefe7ca032f827629160
Cr-Commit-Position: refs/heads/master@{#402619}

Powered by Google App Engine
This is Rietveld 408576698