net: Change auto to not deduce raw pointers.

net: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=agl, danakj, dcheng
BUG=554600
Committed: https://crrev.com/6f21f24e143e691e3635c06e906b1f8917d33dbd
Cr-Commit-Position: refs/heads/master@{#402661}

[vmpstr, 2016-06-28 21:40:08]

Please take a look.

[agl, 2016-06-28 23:01:53]

Can you explain why you want to do this? (The bug wasn't enlightening.)

[vmpstr, 2016-06-28 23:15:47]

On 2016/06/28 23:01:53, agl wrote:
> Can you explain why you want to do this? (The bug wasn't enlightening.)

My main motivation for this is to amend the style guide, letting developers use
auto for smart pointers. Specifically, the current situation is that

auto foo = CreateFoo();

makes it unclear whether |foo| is a raw pointer or a smart pointer, making it
difficult to figure out what is the proper way to clean this up.

With this change, and the subsequent change to enable the no-auto-raw-pointer
check by default, the line above would only compile if CreateFoo() returns a
smart pointer. With a raw pointer, you'd get an error along the lines of:

warning: [chromium-style] auto variable type must not deduce to a raw pointer
type. 
auto foo = CreateFoo();
^~~~
auto*

[agl, 2016-06-28 23:35:53]

lgtm

[vmpstr, 2016-06-29 00:32:12]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-06-29 00:34:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:17:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 02:19:52]

Description was changed from

==========
net: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=agl, danakj, dcheng
BUG=554600
==========

to

==========
net: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=agl, danakj, dcheng
BUG=554600

Committed: https://crrev.com/6f21f24e143e691e3635c06e906b1f8917d33dbd
Cr-Commit-Position: refs/heads/master@{#402661}
==========

[commit-bot: I haz the power, 2016-06-29 02:19:53]

Patchset 1 (id:??) landed as
https://crrev.com/6f21f24e143e691e3635c06e906b1f8917d33dbd
Cr-Commit-Position: refs/heads/master@{#402661}