Add signal handler for low disk notification

Add signal handler for low disk notification

Cryptohome polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications

Committed: https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4
Cr-Commit-Position: refs/heads/master@{#403089}

[dspaid1, 2016-06-28 00:39:44]

dspaid@google.com changed reviewers:
+ dspaid@google.com, satorux@chromium.org, yoshiki@chromium.org

[satorux1, 2016-06-28 00:48:29]

https://codereview.chromium.org/2101853002/diff/1/chromeos/dbus/fake_cryptoho...
File chromeos/dbus/fake_cryptohome_client.cc (right):

https://codereview.chromium.org/2101853002/diff/1/chromeos/dbus/fake_cryptoho...
chromeos/dbus/fake_cryptohome_client.cc:57: low_disk_space_handler_ = handler;
low_disk_space_handler_ is set but won't be used? Then I think we don't need
this member variable for now.

[dspaid, 2016-06-28 00:57:08]

https://codereview.chromium.org/2101853002/diff/1/chromeos/dbus/fake_cryptoho...
File chromeos/dbus/fake_cryptohome_client.cc (right):

https://codereview.chromium.org/2101853002/diff/1/chromeos/dbus/fake_cryptoho...
chromeos/dbus/fake_cryptohome_client.cc:57: low_disk_space_handler_ = handler;
On 2016/06/28 00:48:29, satorux1 wrote:
> low_disk_space_handler_ is set but won't be used? Then I think we don't need
> this member variable for now.

Done.

[satorux1, 2016-06-28 01:13:34]

I think it might be nice to add some more info in the patch description. For
instance, it might be nice to briefly mention how cryptohome detects the low
disk situation .

LGTM with a request the below:

https://codereview.chromium.org/2101853002/diff/20001/chromeos/dbus/mock_cryp...
File chromeos/dbus/mock_cryptohome_client.h (right):

https://codereview.chromium.org/2101853002/diff/20001/chromeos/dbus/mock_cryp...
chromeos/dbus/mock_cryptohome_client.h:31:
MOCK_METHOD0(ResetLowDiskSpaceHandler, void());
please remove this.

[dspaid, 2016-06-28 01:43:34]

Description was changed from

==========
Add signal handler for low disk notification

BUG=622590
TEST=unit tests in following CL to implement notifications
==========

to

==========
Add signal handler for low disk notification

ChromeOS polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications
==========

[dspaid, 2016-06-28 01:44:02]

https://codereview.chromium.org/2101853002/diff/20001/chromeos/dbus/mock_cryp...
File chromeos/dbus/mock_cryptohome_client.h (right):

https://codereview.chromium.org/2101853002/diff/20001/chromeos/dbus/mock_cryp...
chromeos/dbus/mock_cryptohome_client.h:31:
MOCK_METHOD0(ResetLowDiskSpaceHandler, void());
On 2016/06/28 01:13:34, satorux1 wrote:
> please remove this.

Done.

[yoshiki, 2016-06-28 04:01:19]

lgtm

[satorux1, 2016-06-28 04:12:00]

nit in the description: ChromeOS -> Cryptohome?

[dspaid, 2016-06-28 04:12:51]

Description was changed from

==========
Add signal handler for low disk notification

ChromeOS polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications
==========

to

==========
Add signal handler for low disk notification

Cryptohome polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications
==========

[dspaid, 2016-06-28 04:13:51]

On 2016/06/28 04:12:00, satorux1 wrote:
> nit in the description: ChromeOS -> Cryptohome?

Done

[satorux1, 2016-06-28 05:45:17]

lgtm

[dspaid1, 2016-06-30 02:16:49]

The CQ bit was checked by dspaid@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 02:17:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 02:32:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 02:32:23]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[dspaid, 2016-06-30 04:28:13]

The CQ bit was checked by dspaid@chromium.org

[commit-bot: I haz the power, 2016-06-30 04:28:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 04:48:58]

Description was changed from

==========
Add signal handler for low disk notification

Cryptohome polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications
==========

to

==========
Add signal handler for low disk notification

Cryptohome polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications
==========

[commit-bot: I haz the power, 2016-06-30 04:48:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 04:49:06]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 04:50:53]

Description was changed from

==========
Add signal handler for low disk notification

Cryptohome polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications
==========

to

==========
Add signal handler for low disk notification

Cryptohome polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG=622590
TEST=unit tests in following CL to implement notifications

Committed: https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4
Cr-Commit-Position: refs/heads/master@{#403089}
==========

[commit-bot: I haz the power, 2016-06-30 04:50:55]

Patchset 3 (id:??) landed as
https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4
Cr-Commit-Position: refs/heads/master@{#403089}