[ash-md] Animates a window closed while in overview mode

ash/wm/overview/scoped_overview_animation_settings_aura.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/scoped_overview_animation_settings_aura.h"
 
 #include "base/time/time.h"
 #include "ui/aura/window.h"
 #include "ui/compositor/layer.h"
 #include "ui/gfx/animation/tween.h"
 
 namespace ash {
 
 namespace {
 
 // The time duration for transformation animations.
 const int kTransitionMilliseconds = 200;
 
+// The time duration for layout update. Only different with Material Design;

[tdanderson, 2016/06/28 15:28:02]

nit: ;

Also reading this I find "only different with material design" confusing. Where
do I see the non-MD value?

[varkha, 2016/06/28 23:50:37]

Done.

+const int kCloseTransitionMillisecondsMD = 200;

[tdanderson, 2016/06/28 15:28:02]

nit: it was suggested to me in a separate CL to use Md rather than MD as a
suffix to conform to chrome naming conventions. Though you're consistently using
MD throughout overview code so not a big deal leaving it as-is.

[varkha, 2016/06/28 23:50:37]

Done.

+
 // The time duration for widgets to fade in.
 const int kFadeInMilliseconds = 80;
 
 base::TimeDelta GetAnimationDuration(OverviewAnimationType animation_type) {
   switch (animation_type) {
     case OVERVIEW_ANIMATION_NONE:
       return base::TimeDelta();
     case OVERVIEW_ANIMATION_ENTER_OVERVIEW_MODE_FADE_IN:
       return base::TimeDelta::FromMilliseconds(kFadeInMilliseconds);
     case OVERVIEW_ANIMATION_LAY_OUT_SELECTOR_ITEMS:
     case OVERVIEW_ANIMATION_RESTORE_WINDOW:
     case OVERVIEW_ANIMATION_HIDE_WINDOW:
       return base::TimeDelta::FromMilliseconds(kTransitionMilliseconds);
+    case OVERVIEW_ANIMATION_CLOSE_SELECTOR_ITEM:
+      return base::TimeDelta::FromMilliseconds(kCloseTransitionMillisecondsMD);
   }
   NOTREACHED();
   return base::TimeDelta();
 }
 
 }  // namespace
 
 ScopedOverviewAnimationSettingsAura::ScopedOverviewAnimationSettingsAura(
     OverviewAnimationType animation_type,
     aura::Window* window)
@@ skipping 10 matching lines @@
           ui::LayerAnimationElement::OPACITY);
       animation_settings_.SetPreemptionStrategy(
           ui::LayerAnimator::REPLACE_QUEUED_ANIMATIONS);
       break;
     case OVERVIEW_ANIMATION_LAY_OUT_SELECTOR_ITEMS:
     case OVERVIEW_ANIMATION_RESTORE_WINDOW:
       animation_settings_.SetPreemptionStrategy(
           ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
       animation_settings_.SetTweenType(gfx::Tween::FAST_OUT_SLOW_IN);
       break;
+    case OVERVIEW_ANIMATION_CLOSE_SELECTOR_ITEM:
+      animation_settings_.SetPreemptionStrategy(
+          ui::LayerAnimator::ENQUEUE_NEW_ANIMATION);
+      animation_settings_.SetTweenType(gfx::Tween::EASE_OUT);
+      break;
     case OVERVIEW_ANIMATION_HIDE_WINDOW:
       animation_settings_.SetPreemptionStrategy(
           ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
       break;
   }
   animation_settings_.SetTransitionDuration(
       GetAnimationDuration(animation_type));
 }
 
 ScopedOverviewAnimationSettingsAura::~ScopedOverviewAnimationSettingsAura() {}
 
 }  // namespace ash