Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: remoting/client/plugin/pepper_video_renderer_2d.cc

Issue 2101833002: [Remoting Android] DisplayUpdaterFactory cleanups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Build Fix again Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_video_renderer_2d.cc
diff --git a/remoting/client/plugin/pepper_video_renderer_2d.cc b/remoting/client/plugin/pepper_video_renderer_2d.cc
index 120b330a2926463f0eefbcf1f0e368c7f8fd4d1f..ace49b220f24ad1d5194f8494b1dddb6d81a90f1 100644
--- a/remoting/client/plugin/pepper_video_renderer_2d.cc
+++ b/remoting/client/plugin/pepper_video_renderer_2d.cc
@@ -21,7 +21,6 @@
#include "ppapi/cpp/size.h"
#include "remoting/base/util.h"
#include "remoting/client/client_context.h"
-#include "remoting/client/software_video_renderer.h"
#include "remoting/proto/video.pb.h"
#include "remoting/protocol/performance_tracker.h"
#include "third_party/libyuv/include/libyuv/scale_argb.h"
@@ -55,16 +54,15 @@ class PepperDesktopFrame : public webrtc::DesktopFrame {
} // namespace
PepperVideoRenderer2D::PepperVideoRenderer2D()
- : callback_factory_(this),
+ : software_video_renderer_(this),
+ callback_factory_(this),
weak_factory_(this) {}
PepperVideoRenderer2D::~PepperVideoRenderer2D() {}
-bool PepperVideoRenderer2D::Initialize(
+void PepperVideoRenderer2D::SetPepperContext(
pp::Instance* instance,
- const ClientContext& context,
- EventHandler* event_handler,
- protocol::PerformanceTracker* perf_tracker) {
+ EventHandler* event_handler) {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(!instance_);
DCHECK(!event_handler_);
@@ -73,10 +71,6 @@ bool PepperVideoRenderer2D::Initialize(
instance_ = instance;
event_handler_ = event_handler;
- software_video_renderer_.reset(new SoftwareVideoRenderer(
- context.decode_task_runner(), this, perf_tracker));
-
- return true;
}
void PepperVideoRenderer2D::OnViewChanged(const pp::View& view) {
@@ -102,23 +96,33 @@ void PepperVideoRenderer2D::EnableDebugDirtyRegion(bool enable) {
debug_dirty_region_ = enable;
}
+bool PepperVideoRenderer2D::Initialize(
+ const ClientContext& client_context,
+ protocol::PerformanceTracker* perf_tracker) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
+ software_video_renderer_.Initialize(client_context, perf_tracker);
Sergey Ulanov 2016/06/29 23:02:12 return the result.
Yuwei 2016/06/29 23:38:02 Done.
+
+ return true;
+}
+
void PepperVideoRenderer2D::OnSessionConfig(
const protocol::SessionConfig& config) {
DCHECK(thread_checker_.CalledOnValidThread());
- software_video_renderer_->OnSessionConfig(config);
+ software_video_renderer_.OnSessionConfig(config);
}
protocol::VideoStub* PepperVideoRenderer2D::GetVideoStub() {
DCHECK(thread_checker_.CalledOnValidThread());
- return software_video_renderer_->GetVideoStub();
+ return software_video_renderer_.GetVideoStub();
}
protocol::FrameConsumer* PepperVideoRenderer2D::GetFrameConsumer() {
DCHECK(thread_checker_.CalledOnValidThread());
- return software_video_renderer_->GetFrameConsumer();
+ return software_video_renderer_.GetFrameConsumer();
}
std::unique_ptr<webrtc::DesktopFrame> PepperVideoRenderer2D::AllocateFrame(

Powered by Google App Engine
This is Rietveld 408576698