[Chromium] Context menu option to print when right clicked on an image

Context menu option to print when right clicked on an image

This change is spanning both blink and chromium. This part is for the chromium side changes.

BUG=96121
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214478

[vivekg_samsung, 2013-07-29 08:03:51]

Please take a look.

[vivekg_samsung, 2013-07-29 08:22:04]

Blink side change: https://codereview.chromium.org/21037002/

[jochen (gone - plz use gerrit), 2013-07-29 13:55:26]

lgtm

[commit-bot: I haz the power, 2013-07-29 14:32:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/21018003/1

[commit-bot: I haz the power, 2013-07-29 14:54:40]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-07-29 19:50:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/21018003/1

[commit-bot: I haz the power, 2013-07-30 05:09:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/21018003/1

[commit-bot: I haz the power, 2013-07-30 17:55:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/21018003/1

[commit-bot: I haz the power, 2013-07-31 00:02:48]

Change committed as 214478

[Nico, 2013-08-01 16:33:42]

Huh, was this approved by UI? Normally, we try to _remove_ stuff from chrome's
context menus over time, not add to them.

[jochen (gone - plz use gerrit), 2013-08-01 20:35:26]

On 2013/08/01 16:33:42, Nico (vacation Aug 2 - Aug 22) wrote:
> Huh, was this approved by UI? Normally, we try to _remove_ stuff from chrome's
> context menus over time, not add to them.

no. I figured that just being able to print some media but not others was a bit
inconsistent. Anyway, i'll ask for an ui-review

[brettw, 2013-08-06 00:06:05]

We definitely need this reviewed, can you be sure to file a UI change review bug
also.

My gut feeling is that if we wanted this we would already have it, so I suspect
we don't want it.

[jochen (gone - plz use gerrit), 2013-08-06 01:05:59]

On 2013/08/06 00:06:05, brettw wrote:
> We definitely need this reviewed, can you be sure to file a UI change review
bug
> also.
> 
Added you to the review thread.

> My gut feeling is that if we wanted this we would already have it, so I
suspect
> we don't want it.

I would have hoped that we'd close such an old bug if we didn't want to have it
:-/

[brettw, 2013-08-06 04:03:23]

On 2013/08/06 01:05:59, jochen wrote:
> On 2013/08/06 00:06:05, brettw wrote:
> > We definitely need this reviewed, can you be sure to file a UI change review
> bug
> > also.
> > 
> Added you to the review thread.
> 
> > My gut feeling is that if we wanted this we would already have it, so I
> suspect
> > we don't want it.
> 
> I would have hoped that we'd close such an old bug if we didn't want to have
it
> :-/

We close old bugs? News to me!

[jochen (gone - plz use gerrit), 2013-08-07 03:27:27]

UI approved