[Chromoting] Feedback animation has stopped

remoting/android/java/src/org/chromium/chromoting/DesktopView.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
 import android.graphics.Color;
@@ skipping 183 matching lines @@
             Bitmap cursorBitmap = mClient.getDisplay().getCursorBitmap();
             if (cursorBitmap != null) {
                 Point hotspot = mClient.getDisplay().getCursorHotspot();
                 canvas.drawBitmap(cursorBitmap, cursorPosition.x - hotspot.x,
                         cursorPosition.y - hotspot.y, new Paint());
             }
         }
 
         getHolder().unlockCanvasAndPost(canvas);
 
-        synchronized (mAnimationLock) {
-            if (mInputAnimationRunning) {
-                getHandler().postAtTime(new Runnable() {
-                    @Override
-                    public void run() {
-                        processAnimation();
-                    }
-                }, startTimeMs + 30);
+        getHandler().postAtTime(new Runnable() {

[Yuwei, 2016/06/29 01:17:43]

I'm not sure whether this is a good solution if it ends up to be the last CL
that fixes the problem in M53. Compared to previous versions it always call
procesAnimation even if that is a no-op...

Are you going to bundle the change of TouchInputHandler.processAnimation with
some other changes? I just feel like it is easy to turn it into an event
listener pattern...

[Hzj_jie, 2016/06/29 01:38:11]

Done.

+            @Override
+            public void run() {
+                processAnimation();
             }
-        }
+        }, startTimeMs + 30);
     }
 
     private void processAnimation() {
         boolean running;
         synchronized (mAnimationLock) {
             running = mInputAnimationRunning;
         }
         if (running) {
             mInputHandler.processAnimation();
             requestRepaint();
@@ skipping 100 matching lines @@
     @Override
     public void setAnimationEnabled(boolean enabled) {
         synchronized (mAnimationLock) {
             if (enabled && !mInputAnimationRunning) {
                 requestRepaint();
             }
             mInputAnimationRunning = enabled;
         }
     }
 }