Issue 2101773002: Add crash keys to LocalDOMWindow to help diagnose bug 621730.

Issue 2101773002: Add crash keys to LocalDOMWindow to help diagnose bug 621730. (Closed)

Created:
4 years, 5 months ago by ncarter (slow)

Modified:
4 years, 5 months ago

Reviewers:
dcheng

CC:
chromium-reviews, blink-reviews, esprehn, haraken

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add crash keys to LocalDOMWindow to help diagnose bug 621730. This change can be reverted after a day or two of data. BUG=621730

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
M	blimp/engine/app/blimp_engine_crash_keys.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/crash_keys.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

ncarter (slow)

dcheng: Can we use crash keys in blink? I don't think debug::Alias would get the ...

4 years, 5 months ago (2016-06-27 22:14:59 UTC) #3

dcheng

I talked with haraken@, and for now, the preferred approach is to expose //base APIs ...

4 years, 5 months ago (2016-06-28 03:32:58 UTC) #4

Yuki

On 2016/06/28 03:32:58, dcheng wrote: > I talked with haraken@, and for now, the preferred ...

4 years, 5 months ago (2016-06-28 12:08:36 UTC) #5

Thanks, Yuki. I'll close this one.