Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 210173002: Add tools to generated Android.mk (Closed)

Created:
6 years, 9 months ago by scroggo
Modified:
6 years, 9 months ago
Reviewers:
hal.canary, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add tools to generated Android.mk Include the skia tools (bench, gm, tests) in the generated Android make file for the framework. They are commented out, so that a tester can include them if desired. BUG=skia:1975 Committed: http://code.google.com/p/skia/source/detail?r=13915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M platform_tools/android/gyp_gen/makefile_writer.py View 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
6 years, 9 months ago (2014-03-24 16:05:49 UTC) #1
hal.canary
lgtm
6 years, 9 months ago (2014-03-24 16:40:53 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 9 months ago (2014-03-24 17:01:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/210173002/1
6 years, 9 months ago (2014-03-24 17:02:01 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 18:26:43 UTC) #5
Message was sent while issue was closed.
Change committed as 13915

Powered by Google App Engine
This is Rietveld 408576698