Fix a regression from commit f3e6851.

Fix a regression from commit f3e6851.

The index calculations are wrong for a reverse iterator.

Committed: https://pdfium.googlesource.com/pdfium/+/b21c6d0083e18077aa09b8cb1e4bb867dab2949e

[Lei Zhang, 2016-06-27 19:14:47]

thestig@chromium.org changed reviewers:
+ olsen@google.com

[Lei Zhang, 2016-06-27 21:58:30]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org, weili@chromium.org

[Lei Zhang, 2016-06-27 21:58:31]

Add more reviewers in case the CQ doesn't like olsen@.

[olsen, 2016-06-28 00:53:19]

lgtm

https://codereview.chromium.org/2101723002/diff/1/core/fxge/android/fpf_skiaf...
File core/fxge/android/fpf_skiafontmgr.cpp (right):

https://codereview.chromium.org/2101723002/diff/1/core/fxge/android/fpf_skiaf...
core/fxge/android/fpf_skiafontmgr.cpp:309: nItem = m_FontFaces.rend() - it - 1;
This will work, but it is prone to the same type of bugs as was introduced last
refactoring. Instead of nItem, an integer index or reverse index, consider
keeping a pointer to the best font so far eg:

CFPF_SkiaFontDescriptor* pBestFont;

[Lei Zhang, 2016-06-28 01:11:26]

PTAL at patch set 2.

https://codereview.chromium.org/2101723002/diff/1/core/fxge/android/fpf_skiaf...
File core/fxge/android/fpf_skiafontmgr.cpp (right):

https://codereview.chromium.org/2101723002/diff/1/core/fxge/android/fpf_skiaf...
core/fxge/android/fpf_skiafontmgr.cpp:309: nItem = m_FontFaces.rend() - it - 1;
On 2016/06/28 00:53:18, olsen wrote:
> This will work, but it is prone to the same type of bugs as was introduced
last
> refactoring. Instead of nItem, an integer index or reverse index, consider
> keeping a pointer to the best font so far eg:
> 
> CFPF_SkiaFontDescriptor* pBestFont;

Done.

[olsen, 2016-06-28 01:13:16]

lgtm

[Lei Zhang, 2016-06-28 01:14:42]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-28 01:14:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 01:22:13]

Description was changed from

==========
Fix a regression from commit f3e6851.

The index calculations are wrong for a reverse iterator.
==========

to

==========
Fix a regression from commit f3e6851.

The index calculations are wrong for a reverse iterator.

Committed:
https://pdfium.googlesource.com/pdfium/+/b21c6d0083e18077aa09b8cb1e4bb867dab2...
==========

[commit-bot: I haz the power, 2016-06-28 01:22:14]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b21c6d0083e18077aa09b8cb1e4bb867dab2...