experimental/PdfViewer/generate_code.py - Issue 21017004: pdfviewer: fix condition for element in array, reset back the default color to white, and verify ty…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/generate_code.py

Issue 21017004: pdfviewer: fix condition for element in array, reset back the default color to white, and verify ty… (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: experimental/PdfViewer/generate_code.py

===================================================================

--- experimental/PdfViewer/generate_code.py (revision 10402)

+++ experimental/PdfViewer/generate_code.py (working copy)

@@ -518,7 +518,7 @@

cntMust = cntMust + 1

fileMapperNativeCpp.write(' if (!nativeObj->isDictionary()) return false;\n')

fileMapperNativeCpp.write(' ret = nativeObj->get(\"' + prop.fName + '\", \"' + prop.fAbr + '\");\n')

- fileMapperNativeCpp.write(' if (ret == NULL) return false;\n')

+ fileMapperNativeCpp.write(' if (ret == NULL || !' + knowTypes[prop.fTypes.strip()][3] + ') return false;\n')

eval = '';

# TODO(edisonn): this could get out of hand, and could have poor performance if continued on this path

« no previous file with comments | « no previous file | experimental/PdfViewer/pdf_viewer_main.cpp » ('j') | no next file with comments »