pdfviewer: fix condition for element in array, reset back the default color to white, and verify ty…

experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp

 #include "SkNativeParsedPDF.h"
 #include "SkPdfNativeTokenizer.h"
 #include "SkPdfBasics.h"
 #include "SkPdfObject.h"
 
 #include <stdio.h>
 #include <string.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 
@@ skipping 486 matching lines @@
 // TODO(edisonn): fix infinite loop if ref to itself!
 // TODO(edisonn): perf, fix refs at load, and resolve will simply return fResolvedReference?
 SkPdfObject* SkNativeParsedPDF::resolveReference(const SkPdfObject* ref) {
     if (ref && ref->isReference()) {
         int id = ref->referenceId();
         // TODO(edisonn): generation/updates not supported now
         //int gen = ref->referenceGeneration();
 
         SkASSERT(!(id < 0 || id > fObjects.count()));
 
-        if (id < 0 || id > fObjects.count()) {
+        // TODO(edisonn): verify id and gen expected
+        if (id < 0 || id >= fObjects.count()) {
+            // TODO(edisonn): report error/warning
             return NULL;
         }
 
-        // TODO(edisonn): verify id and gen expected
-
         if (fObjects[id].fResolvedReference != NULL) {
             return fObjects[id].fResolvedReference;
         }
 
         if (fObjects[id].fObj == NULL) {
             fObjects[id].fObj = readObject(id);
         }
 
         if (fObjects[id].fResolvedReference == NULL) {
             if (!fObjects[id].fObj->isReference()) {
                 fObjects[id].fResolvedReference = fObjects[id].fObj;
             } else {
                 fObjects[id].fResolvedReference = resolveReference(fObjects[id].fObj);
             }
         }
 
         return fObjects[id].fResolvedReference;
     }
     // TODO(edisonn): fix the mess with const, probably we need to remove it pretty much everywhere
     return (SkPdfObject*)ref;
 }
 
 size_t SkNativeParsedPDF::bytesUsed() const {
     return fAllocator->bytesUsed() +
            fContentLength +
            fObjects.count() * sizeof(PublicObjectEntry) +
            fPages.count() * sizeof(SkPdfPageObjectDictionary*) +
            sizeof(*this);
 }