Send synthetic GestureTapDown to focus BrowserPlugin

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_guest.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 157 matching lines @@
 
 void RenderWidgetHostViewGuest::ProcessTouchEvent(
     const blink::WebTouchEvent& event,
     const ui::LatencyInfo& latency) {
   if (event.type == blink::WebInputEvent::TouchStart) {
     DCHECK(guest_->GetOwnerRenderWidgetHostView());
     RenderWidgetHostImpl* embedder = static_cast<RenderWidgetHostImpl*>(
         guest_->GetOwnerRenderWidgetHostView()->GetRenderWidgetHost());
     if (!embedder->GetView()->HasFocus())
       embedder->GetView()->Focus();
+
+    // Since we now route GestureEvents directly to the guest renderer, we need
+    // a way to make sure that the BrowserPlugin in the embedder gets focused so
+    // that keyboard input (which still travels via BrowserPlugin) is routed to
+    // the plugin and thus onwards to the guest.
+    // TODO(wjmaclean): When we remove BrowserPlugin, delete this code.
+    // http://crbug.com/533069
+    if (!HasFocus()) {
+      auto offset_in_owner = GetViewBounds().origin();
+      auto owner_offset =
+          GetOwnerRenderWidgetHostView()->GetBoundsInRootWindow();

[tdresser, 2016/06/30 13:20:57]

I think using an explicit type here would be better.

Maybe just:
gfx::Vector2D offset = GetViewBounds().origin() -
GetOwnerRenderWidgetHostView()->GetBoundsInRootWindow();

You might want to add a comment describing why the offset is needed, or pick a
more descriptive name.

[wjmaclean, 2016/06/30 20:33:47]

Done.

+      blink::WebGestureEvent gesture_tap_event;
+      gesture_tap_event.sourceDevice = blink::WebGestureDeviceTouchscreen;
+      gesture_tap_event.type = blink::WebGestureEvent::GestureTapDown;
+      gesture_tap_event.x =
+          event.touches[0].position.x + offset_in_owner.x() - owner_offset.x();
+      gesture_tap_event.y =
+          event.touches[0].position.y + offset_in_owner.y() - owner_offset.y();

[tdresser, 2016/06/30 13:20:57]

Can you do this math directly on the Point/Vector objects, instead of handling
x/y separately? (If it isn't cleaner, don't bother)

[wjmaclean, 2016/06/30 20:33:47]

WebFloatPoint supports conversion to gfx::PointF but that won't add with
gfx::Vector2d, so we need to deal with individual coordinates somewhere along
the way. I've simplified it somewhat.

+      gesture_tap_event.globalX = event.touches[0].screenPosition.x;
+      gesture_tap_event.globalY = event.touches[0].screenPosition.y;
+      GetOwnerRenderWidgetHostView()->ProcessGestureEvent(gesture_tap_event,
+                                                          ui::LatencyInfo());
+      gesture_tap_event.type = blink::WebGestureEvent::GestureTapCancel;
+      GetOwnerRenderWidgetHostView()->ProcessGestureEvent(gesture_tap_event,
+                                                          ui::LatencyInfo());

[tdresser, 2016/06/30 13:20:57]

We should send a tap cancel here, to ensure the event stream is valid. This
seems correct.

[wjmaclean, 2016/06/30 20:33:47]

Acknowledged.

+    }
   }
 
   host_->ForwardTouchEventWithLatencyInfo(event, latency);
 }
 
 gfx::Rect RenderWidgetHostViewGuest::GetViewBounds() const {
   if (!guest_)
     return gfx::Rect();
 
   RenderWidgetHostViewBase* rwhv = GetOwnerRenderWidgetHostView();
@@ skipping 406 matching lines @@
         gesture_event.data.scrollUpdate.inertialPhase ==
             blink::WebGestureEvent::MomentumPhase) {
       return;
     }
     host_->ForwardGestureEvent(gesture_event);
     return;
   }
 }
 
 }  // namespace content