Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2101543002: Implement StreamVideoDrawQuad StructTraits (Closed)

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
ajuma, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement StreamVideoDrawQuad StructTraits This CL allows StreamVideoDrawQuad to be serialized and deserialized over mojo. BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/255c018fa556271caec3b2ff6cd573fc371e8a0f Cr-Commit-Position: refs/heads/master@{#402268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -9 lines) Patch
M cc/ipc/quads.mojom View 2 chunks +6 lines, -1 line 0 comments Download
M cc/ipc/quads_struct_traits.h View 2 chunks +37 lines, -3 lines 0 comments Download
M cc/ipc/quads_struct_traits.cc View 3 chunks +16 lines, -3 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M cc/quads/stream_video_draw_quad.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Fady Samuel
+ajuma@ for cc +dcheng@ for security review.
4 years, 5 months ago (2016-06-27 09:01:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101543002/1
4 years, 5 months ago (2016-06-27 12:07:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 12:49:54 UTC) #7
ajuma
lgtm
4 years, 5 months ago (2016-06-27 13:41:59 UTC) #8
dcheng
LGTM
4 years, 5 months ago (2016-06-27 20:08:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101543002/1
4 years, 5 months ago (2016-06-27 20:10:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 20:15:11 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 20:18:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/255c018fa556271caec3b2ff6cd573fc371e8a0f
Cr-Commit-Position: refs/heads/master@{#402268}

Powered by Google App Engine
This is Rietveld 408576698