Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 210153004: Beautify the gaia signin view (Closed)

Created:
6 years, 9 months ago by guohui
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M chrome/browser/ui/views/profile_chooser_view.cc View 3 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
guohui
Hey, could you please take a look at the CL? Thanks, Hui
6 years, 9 months ago (2014-03-25 20:40:12 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Sorry for delay.
6 years, 9 months ago (2014-03-27 15:56:20 UTC) #2
guohui
On 2014/03/27 15:56:20, Roger Tawa wrote: > lgtm > > Sorry for delay. thanks roger! ...
6 years, 9 months ago (2014-03-27 17:30:39 UTC) #3
sky
LGTM
6 years, 9 months ago (2014-03-27 19:36:36 UTC) #4
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-27 19:37:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/210153004/30001
6 years, 9 months ago (2014-03-27 19:39:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:26:01 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 23:26:01 UTC) #8
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-28 01:26:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/210153004/30001
6 years, 9 months ago (2014-03-28 01:29:38 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 01:32:43 UTC) #11
Message was sent while issue was closed.
Change committed as 260056

Powered by Google App Engine
This is Rietveld 408576698