src/crankshaft/x64/lithium-codegen-x64.h - Issue 2101523003: Use source position table for crankshaft code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.h

Issue 2101523003: Use source position table for crankshaft code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@sourcepos

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.h

diff --git a/src/crankshaft/x64/lithium-codegen-x64.h b/src/crankshaft/x64/lithium-codegen-x64.h

index c586ef59af25c9fe614829758051b60442f70bfb..8fb27e5f6a68dbc689d47ffeb99b8eb5e627fb30 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.h

+++ b/src/crankshaft/x64/lithium-codegen-x64.h

@@ -238,7 +238,7 @@ class LCodeGen: public LCodeGenBase {

void EmitIntegerMathAbs(LMathAbs* instr);

void EmitSmiMathAbs(LMathAbs* instr);

- // Support for recording safepoint and position information.

+ // Support for recording safepoint information.

void RecordSafepoint(LPointerMap* pointers,

Safepoint::Kind kind,

int arguments,

@@ -248,7 +248,6 @@ class LCodeGen: public LCodeGenBase {

void RecordSafepointWithRegisters(LPointerMap* pointers,

int arguments,

Safepoint::DeoptMode mode);

- void RecordAndWritePosition(int position) override;

static Condition TokenToCondition(Token::Value op, bool is_unsigned);

void EmitGoto(int block);