Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2101523003: Use source position table for crankshaft code. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@sourcepos
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use source position table for crankshaft code. R=bmeurer@chromium.org BUG=v8:5117 Committed: https://crrev.com/b1063f7a4173026e6b24122ea5af492351cdd922 Cr-Commit-Position: refs/heads/master@{#37357}

Patch Set 1 #

Patch Set 2 : fix profiler. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -93 lines) Patch
M src/crankshaft/arm/lithium-codegen-arm.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/crankshaft/lithium-codegen.h View 4 chunks +6 lines, -1 line 0 comments Download
M src/crankshaft/lithium-codegen.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/profiler/profiler-listener.cc View 1 1 chunk +14 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
Yang
4 years, 5 months ago (2016-06-27 11:10:46 UTC) #1
Benedikt Meurer
4 years, 5 months ago (2016-06-27 11:33:37 UTC) #3
Yang
Now that the predecessor CL has landed, please take a look at this :)
4 years, 5 months ago (2016-06-28 06:00:00 UTC) #4
Michael Starzinger
LGTM. But you still need owners stamp.
4 years, 5 months ago (2016-06-28 13:00:27 UTC) #5
Benedikt Meurer
LGTM (owners stamp)
4 years, 5 months ago (2016-06-29 03:55:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101523003/40001
4 years, 5 months ago (2016-06-29 03:56:20 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 04:27:40 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 04:29:24 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b1063f7a4173026e6b24122ea5af492351cdd922
Cr-Commit-Position: refs/heads/master@{#37357}

Powered by Google App Engine
This is Rietveld 408576698