Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2101523002: Make HTML tree builder simulator switch modes at HTML integration points (Closed)

Created:
4 years, 5 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 5 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make HTML tree builder simulator switch modes at HTML integration points The title element contains RCDATA per the living HTML standard: https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inhead where as title element historically contained PCDATA in HTML 4.01: https://www.w3.org/TR/html4/struct/global.html#h-7.4.2 BUG=542803 Committed: https://crrev.com/30869b3a11a19398108e1ba1254858f3fcc735ca Cr-Commit-Position: refs/heads/master@{#403630}

Patch Set 1 #

Patch Set 2 : Track HTML integration points on the simulated stack. #

Patch Set 3 : Increase the coverage of the C++ unit test. #

Patch Set 4 : Fix? MSVC unsigned/signed complaints. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -35 lines) Patch
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h View 1 2 3 4 chunks +30 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 1 2 3 3 chunks +72 lines, -23 lines 0 comments Download
A third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp View 1 2 1 chunk +72 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (6 generated)
dominicc (has gone to gerrit)
PTAL This is more involved than I thought and it is imprecise in some annotation-xml ...
4 years, 5 months ago (2016-06-30 02:23:14 UTC) #4
dominicc (has gone to gerrit)
Ping!
4 years, 5 months ago (2016-07-04 00:06:23 UTC) #5
kouhei (in TOK)
code lgtm Would you note the following in the description?: The title element contains RCDATA ...
4 years, 5 months ago (2016-07-04 00:25:49 UTC) #6
kouhei (in TOK)
https://codereview.chromium.org/2101523002/diff/60001/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp File third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp (right): https://codereview.chromium.org/2101523002/diff/60001/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp#newcode1 third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
4 years, 5 months ago (2016-07-04 00:25:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101523002/60001
4 years, 5 months ago (2016-07-04 02:02:51 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-04 03:22:38 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 03:24:52 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/30869b3a11a19398108e1ba1254858f3fcc735ca
Cr-Commit-Position: refs/heads/master@{#403630}

Powered by Google App Engine
This is Rietveld 408576698