Issue 21015010: Remove all traces of deprecated Get/SetReleaseTrack calls.

Issue 21015010: Remove all traces of deprecated Get/SetReleaseTrack calls. (Closed)

Created:
7 years, 4 months ago by sosa

Modified:
7 years, 4 months ago

Reviewers:
xiyuan, stevenjb, ygorshenin1, Mattias Nissler (ping if slow), Paweł Hajdan Jr.

CC:
chromium-reviews, nkostylev+watch_chromium.org, dyu1, anantha, robertshield, oshima+watch_chromium.org, dennis_jeffrey, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove all traces of deprecated Get/SetReleaseTrack calls. In early M30 we deprecated this API and are planning on removing the calling end in the update engine. This CL removes the browser-side stubs/callbacks and any trace of them left in the code. BUG=chromium:221850 TEST=try + build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215431

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -210 lines)			Patch
M	chrome/browser/automation/testing_automation_provider.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View	3 chunks	+0 lines, -47 lines	0 comments	Download
M	chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/help/help_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/functional/chromeos_update.py	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	chrome/test/pyautolib/pyauto.py	View	2 chunks	+0 lines, -38 lines	0 comments	Download
M	chromeos/dbus/fake_update_engine_client.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chromeos/dbus/fake_update_engine_client.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chromeos/dbus/update_engine_client.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	chromeos/dbus/update_engine_client.cc	View	5 chunks	+2 lines, -64 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sosa@chromium.org/21015010/1

7 years, 4 months ago (2013-07-31 17:34:44 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=18039

7 years, 4 months ago (2013-07-31 17:54:23 UTC) #4

sosa

I don't usually have a test that cuts so many directories so I tried to ...

7 years, 4 months ago (2013-07-31 18:24:42 UTC) #5

Mattias Nissler (ping if slow)

chrome/browser/chromeos/policy LGTM

7 years, 4 months ago (2013-08-01 08:47:54 UTC) #8

sosa

Nikita quick ping on the SetChannel log message in the webui subdir for owners approval?

7 years, 4 months ago (2013-08-02 01:35:13 UTC) #9

sosa

redirect owners approval for webui change to xiyuan? can you take a look?

7 years, 4 months ago (2013-08-02 21:09:31 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sosa@chromium.org/21015010/1

7 years, 4 months ago (2013-08-02 22:16:24 UTC) #12

Message was sent while issue was closed.

Change committed as 215431

Expand Messages | Collapse Messages