Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2101473002: [Turbofan] Allow compiler to elide complex aliasing code. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Allow compiler to elide complex aliasing code. - Add a const bool kSimpleFPAliasing variable for each platform so it's easier for the compiler to eliminate dead code. - Modify RegisterAllocator to use it. LOG=N BUG=v8:4124 Committed: https://crrev.com/5107f1c135afb081ab58e275cde48fe207e7db11 Cr-Commit-Position: refs/heads/master@{#37288}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix unit tests. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -44 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/register-allocator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/register-allocator.cc View 11 chunks +16 lines, -18 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/register-configuration.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/register-configuration.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M src/s390/assembler-s390.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M test/unittests/register-configuration-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bbudge
https://codereview.chromium.org/2101473002/diff/1/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/2101473002/diff/1/src/compiler/register-allocator.cc#newcode1559 src/compiler/register-allocator.cc:1559: assigned_double_registers_->Add(index); Fixes a bug.
4 years, 5 months ago (2016-06-26 23:08:32 UTC) #1
bbudge
I think this change will help keep performance at par for non-ARM targets, especially as ...
4 years, 5 months ago (2016-06-27 00:10:20 UTC) #3
Benedikt Meurer
Makes sense, thx. LGTM.
4 years, 5 months ago (2016-06-27 03:53:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101473002/40001
4 years, 5 months ago (2016-06-27 11:29:37 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-27 11:56:59 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 11:58:02 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5107f1c135afb081ab58e275cde48fe207e7db11
Cr-Commit-Position: refs/heads/master@{#37288}

Powered by Google App Engine
This is Rietveld 408576698