Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: components/exo/surface.cc

Issue 2101453002: Re-land: exo: Take blending into account when setting opaque property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/surface.cc
diff --git a/components/exo/surface.cc b/components/exo/surface.cc
index 07e22f0b906029b002da992a7bb1c3960841fa26..c18dc2f1bd679e2c13200848b4ccff450bbc61c8 100644
--- a/components/exo/surface.cc
+++ b/components/exo/surface.cc
@@ -477,8 +477,7 @@ void Surface::CommitSurfaceHierarchy() {
window_->layer()->SetBounds(
gfx::Rect(window_->layer()->bounds().origin(), content_size_));
window_->layer()->SetFillsBoundsOpaquely(
- state_.alpha == 1.0f &&
jbauman 2016/06/27 20:51:41 So if the blend mode is SkXfermode::kSrc_Mode then
reveman 2016/06/27 20:54:21 We should probably define this as part of the alph
-
+ state_.blend_mode == SkXfermode::kSrc_Mode ||
state_.opaque_region.contains(
gfx::RectToSkIRect(gfx::Rect(content_size_))));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698