chrome/android/webapk/libs/runtime_library/src/README - Issue 2101433002: WebAPK: Move MainActivity#onCreate() to runtime library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/webapk/libs/runtime_library/src/README

Issue 2101433002: WebAPK: Move MainActivity#onCreate() to runtime library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_more_meta2_loader Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/webapk/libs/runtime_library/DEPS ('k') | chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 The runtime library contains the implementation of the Web APK service. It	1 The runtime library contains:

2 implements functionality which Chrome delegates to the Web APK such as	2 1) Implementation of the WebAPK service. The service implements functionality

3 displaying notifications. The library is loaded by a ShellAPK which	3 which Chrome delegates to the WebAPK such as displaying notifications.

4 contains the Web APK's manifest and code to load the runtime library.	4 2) Logic to send intent to Chrome to launch Chrome in WebAPK mode.

5	5

6 The latest version of the runtime library is	6 The library is loaded by a ShellAPK which contains the WebAPK's manifest and

7 extracted from Chrome's APK by the ShellAPK when the Web APK service is created.	7 code to load the runtime library.

8 Since the ShellAPK is updated asynchronously, the runtime library may run within	8

9 an old ShellAPK. For instance, the ShellAPK's Android manifest may be missing	9 The latest version of the runtime library is extracted from Chrome's APK by the

10 some of the permissions that the runtime library is expecting.	10 ShellAPK when it is launched. Since the ShellAPK is updated asynchronously, the

	11 runtime library may run within an old ShellAPK. For instance, the ShellAPK's

	12 Android manifest may be missing some of the permissions that the runtime library

	13 is expecting.

11	14

12 The number in runtime_library_version.gni must be incremented whenever the	15 The number in runtime_library_version.gni must be incremented whenever the

13 runtime library is updated. The WebAPK re-extracts the runtime library from the	16 runtime library is updated. The WebAPK re-extracts the runtime library from the

14 Chrome APK when the version number is incremented.	17 Chrome APK when the version number is incremented.

OLD	NEW