Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2101413002: Provide a convenience array buffer allocator (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
oth, PaweĊ‚ Hajdan Jr., rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide a convenience array buffer allocator BUG=none R=ulan@chromium.org Committed: https://crrev.com/356a85be5d8dd3087c319d73f2e80d16957c9d6b Cr-Commit-Position: refs/heads/master@{#37365}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -95 lines) Patch
M include/v8.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M samples/hello-world.cc View 1 3 chunks +3 lines, -13 lines 0 comments Download
M samples/process.cc View 1 2 chunks +2 lines, -13 lines 0 comments Download
M samples/shell.cc View 1 3 chunks +3 lines, -13 lines 0 comments Download
M src/api.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/interpreter/generate-bytecode-expectations.cc View 1 3 chunks +3 lines, -13 lines 0 comments Download
M test/fuzzer/fuzzer-support.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/fuzzer/fuzzer-support.cc View 1 2 chunks +1 line, -11 lines 0 comments Download
M test/unittests/test-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/test-utils.cc View 1 2 chunks +3 lines, -15 lines 0 comments Download
M tools/parser-shell.cc View 1 3 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-06-28 15:01:42 UTC) #1
jochen (gone - plz use gerrit)
ptal
4 years, 5 months ago (2016-06-28 15:07:27 UTC) #2
ulan
lgtm https://codereview.chromium.org/2101413002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2101413002/diff/1/include/v8.h#newcode3518 include/v8.h:3518: static Allocator* NewSimpleAllocator(); Nit: can we call it ...
4 years, 5 months ago (2016-06-28 15:15:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101413002/20001
4 years, 5 months ago (2016-06-29 07:10:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 07:39:53 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 07:42:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/356a85be5d8dd3087c319d73f2e80d16957c9d6b
Cr-Commit-Position: refs/heads/master@{#37365}

Powered by Google App Engine
This is Rietveld 408576698