Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2101403006: Revert of Add display-resolution caching to GPU IDC (Closed)

Created:
4 years, 5 months ago by ericrk
Modified:
4 years, 5 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@drt
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add display-resolution caching to GPU IDC (patchset #10 id:310001 of https://codereview.chromium.org/2042133002/ ) Reason for revert: This caused stability issues. Reverting until fix is in place. Original issue's description: > Add display-resolution caching to GPU IDC > > In order to save memory and upload time, images which are > going to be drawn at less than their native resolution may > be uploaded at a smaller scale. This change adds additional > caching and upload logic to allow this. > See https://goo.gl/0zCd9Z for a complete description. > > BUG=623688 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:mac_blink_rel;tryserver.blink:win_blink_rel > > Committed: https://crrev.com/bc8acf2632042e5e93982088d5b7dcb7f1c0d168 > Cr-Commit-Position: refs/heads/master@{#402377} TBR=vmpstr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623688 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/80a042718b7407f95e9461222f6b840eb9b4ca73 Cr-Commit-Position: refs/heads/master@{#402606}

Patch Set 1 #

Patch Set 2 : Fix test expectations to prevent revert from impacting LayoutTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -919 lines) Patch
M cc/playback/draw_image.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.h View 1 9 chunks +15 lines, -106 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.cc View 1 25 chunks +130 lines, -302 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller_unittest.cc View 1 8 chunks +4 lines, -506 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
ericrk
Created Revert of Add display-resolution caching to GPU IDC
4 years, 5 months ago (2016-06-28 23:55:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101403006/130001
4 years, 5 months ago (2016-06-28 23:59:13 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:02:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80a042718b7407f95e9461222f6b840eb9b4ca73
Cr-Commit-Position: refs/heads/master@{#402606}

Powered by Google App Engine
This is Rietveld 408576698